[2] Configure firewall rules and policies for the federated learning use case

[ferrarimarco]

• Configure firewall policies for the federated learning use case
• Fix an issue with the core teardown.sh script: remove backend configuration only when destroying the core initialize terraservice, instead of running it in any case after destroying the Terraservices in CORE_TERRASERVICES_DESTROY because CORE_TERRASERVICES_DESTROY might not include initialize.
• Fix an issue with the federated learning use case teardown.sh script: ensure that terraservices are destroyed in order.

[arueth]

Can you remove the - "-e" from the https://github.com/GoogleCloudPlatform/accelerated-platforms/blob/int-federated-learning/test/ci-cd/cloudbuild/uc-federated-learning-terraform.yaml#L37

It prevents the teardown script from running on a deploy failure.

[ferrarimarco]

Can you remove the - "-e" from the https://github.com/GoogleCloudPlatform/accelerated-platforms/blob/int-federated-learning/test/ci-cd/cloudbuild/uc-federated-learning-terraform.yaml#L37

It prevents the teardown script from running on a deploy failure.

Done!

[arueth]

It seems like the build is silently failing on the "Provisioning the core platform":
https://console.cloud.google.com/cloud-build/builds;region=us-central1/36ded629-3cdb-494e-9a10-838a3203ac10?e=13803378&mods=monitoring_api_prod&project=accelerated-platforms#L2499

As it doesn't seem to reach the "Provisioning the use case resources" and just goes straight to the destroy.

[arueth]

I was able to get it to deploy, but it looks like the destroy is failing on "Destroying the services that the core platform depends on"

https://console.cloud.google.com/cloud-build/builds;region=us-central1/0fd89e00-03bf-4311-8c10-4d03e464c5c5?e=13803378&mods=monitoring_api_prod&project=accelerated-platforms#L6722

[ferrarimarco]

It seems like the build is silently failing on the "Provisioning the core platform": https://console.cloud.google.com/cloud-build/builds;region=us-central1/36ded629-3cdb-494e-9a10-838a3203ac10?e=13803378&mods=monitoring_api_prod&project=accelerated-platforms#L2499

As it doesn't seem to reach the "Provisioning the use case resources" and just goes straight to the destroy.

This is the error:

Error: Error creating Feature: googleapi: Error 409: Resource 'projects/accelerated-platforms/locations/global/features/policycontroller' already exists
--
2624 | Details:
2625 | [
2626 | {
2627 | "@type": "type.googleapis.com/google.rpc.ResourceInfo",
2628 | "resourceName": "projects/PROJECT_NAME/locations/global/features/policycontroller"
2629 | }
2630 | ]

I think this is due to the fact that we cannot enable a global feature if it's already enabled. Importing it in the Terraform state would work around this, but it will also disable the feature when running the teardown script. We can sync about this.

I was able to get it to deploy, but it looks like the destroy is failing on "Destroying the services that the core platform depends on"

https://console.cloud.google.com/cloud-build/builds;region=us-central1/0fd89e00-03bf-4311-8c10-4d03e464c5c5?e=13803378&mods=monitoring_api_prod&project=accelerated-platforms#L6722

The cause of this issue was that the use case deploy script initialized core platform configuration files after running the core platform deploy script, so the initialize service didn't configure the backend for use case services. It should be fixed now, I checked the logs.