feat: add support for health-check flag #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an adaptation of GoogleCloudPlatform/cloud-sql-proxy#1271.
kurtisvg
approved these changes
Jul 28, 2022
cmd/root.go
Outdated
Comment on lines
438
to
439
| // Prometheus, health-check | ||
| // enabled. |
There was a problem hiding this comment.
nit: is this line break right?
internal/healthcheck/healthcheck.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package healthcheck tests and communicates the health of the Cloud SQL Auth proxy. |
There was a problem hiding this comment.
Suggested change
| // Package healthcheck tests and communicates the health of the Cloud SQL Auth proxy. | |
| // Package healthcheck tests and communicates the health of the AlloyDB Auth proxy. |
cmd/root.go
Outdated
| // invocation. If a project has not been enabled, no traces or metrics are | ||
| // enabled. | ||
| // Configure collectors before the proxy has started to ensure we are | ||
| // collecting metrics before *ANY* Cloud SQL Admin API calls are made. |
There was a problem hiding this comment.
Suggested change
| // collecting metrics before *ANY* Cloud SQL Admin API calls are made. | |
| // collecting metrics before *ANY* AlloyDB Admin API calls are made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of GoogleCloudPlatform/cloud-sql-proxy#1271.