Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update JUnit dependencies #578

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 26, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.junit.vintage:junit-vintage-engine (source) 5.11.2 -> 5.11.3 age adoption passing confidence
org.junit.platform:junit-platform-commons (source) 1.11.2 -> 1.11.3 age adoption passing confidence
org.junit.platform:junit-platform-engine (source) 1.11.2 -> 1.11.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner August 26, 2024 17:29
@enocom
Copy link
Member

enocom commented Sep 10, 2024

One of these dependencies break our GraalVM tests. See https://github.com/GoogleCloudPlatform/alloydb-java-connector/actions/runs/10552406483 for an example.

For now we'll hold off on these dependencies, especially since it's just a test concern.

@enocom enocom added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 10, 2024
@enocom enocom requested review from a team and removed request for a team September 10, 2024 16:16
@enocom
Copy link
Member

enocom commented Sep 10, 2024

Before we can merge this, we need to figure out what breaks the GraalVM build and fix it. Then we'll be good to take these changes.

@renovate-bot renovate-bot force-pushed the renovate/junit-dependencies branch from f59955b to b32322e Compare October 21, 2024 21:16
@enocom enocom removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 13, 2024
@enocom enocom merged commit f2852b4 into GoogleCloudPlatform:main Nov 14, 2024
13 checks passed
@renovate-bot renovate-bot deleted the renovate/junit-dependencies branch November 14, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants