Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify PSC DNS name is present as a SAN in the server certificate #324

Open
nancynh opened this issue Jun 11, 2024 · 6 comments
Open

Verify PSC DNS name is present as a SAN in the server certificate #324

nancynh opened this issue Jun 11, 2024 · 6 comments
Assignees
@rhatgadkar-goog
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@nancynh
Copy link
Collaborator

nancynh commented Jun 11, 2024

Verify PSC DNS name is present as a SAN in the server certificate. It means removing the existing workaround to check the private IP address instead of the DNS name (#291).
@nancynh nancynh added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jun 11, 2024
@nancynh nancynh self-assigned this Jun 11, 2024
@jackwotherspoon
Copy link
Collaborator

is this a duplicate of #313 ?

@enocom enocom mentioned this issue Jun 24, 2024
Closed
@enocom
Copy link
Member

enocom commented Jun 24, 2024

Yes, let's use this one for tracking.

@nancynh nancynh mentioned this issue Jun 24, 2024
Closed
@jackwotherspoon
Copy link
Collaborator

Good context on the trailing dot being stripped dpkp/kafka-python#2374 (comment)

@jackwotherspoon
Copy link
Collaborator

More good context on this thread: openssl/openssl#11560

@enocom
Copy link
Member

enocom commented Sep 5, 2024

Thanks to @jackwotherspoon for finding this:

openssl/openssl#11560 (comment)

TL;DR: SANs shouldn't have trailing dots.

@enocom
Copy link
Member

enocom commented Sep 17, 2024

RFC 6066 says no trailing dots in SANs.

@enocom enocom assigned rhatgadkar-goog and unassigned nancynh Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhatgadkar-goog rhatgadkar-goog

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: have ssl handshake check hostname GoogleCloudPlatform/alloydb-python-connector
4 participants
@enocom @nancynh @jackwotherspoon @rhatgadkar-goog