feat: add support for PSC #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
psc-support
branch
2 times, most recently
from
86e51a0
to
5a73704
Compare
ttosta-google
force-pushed
the
psc-support
branch
from
5a73704
to
7dc6054
Compare
ttosta-google
requested review from
cthumuluru,
nancynh and
a team
as code owners
enocom
approved these changes
Apr 5, 2024
| # Remove trailing period from PSC DNS name. | ||
| psc_dns = resp_dict.get("pscDnsName") | ||
| if psc_dns: | ||
| psc_dns = psc_dns.rstrip(".") |
There was a problem hiding this comment.
I tried without it and it failed:
> self._sslobj.do_handshake()
E ssl.SSLError: [SSL: SSLV3_ALERT_UNEXPECTED_MESSAGE] sslv3 alert unexpected message (_ssl.c:1131)
jackwotherspoon
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to Python Connector for PSC connections:
Fixes #290