Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: have ssl handshake check hostname #283

Closed
wants to merge 14 commits into from
Closed

fix: have ssl handshake check hostname #283

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8b6b9c8
WIP: check hostname
jackwotherspoon Mar 22, 2024
2caa907
chore: change test server name
jackwotherspoon Mar 28, 2024
265f880
chore: add localhost to test SAN
jackwotherspoon Mar 28, 2024
1e4a4d9
chore: mark extension as non-critical
jackwotherspoon Mar 28, 2024
80a4c23
chore: fix type
jackwotherspoon Mar 28, 2024
391cc92
chore: add DNSName
jackwotherspoon Mar 28, 2024
de74efc
chore: merge main
jackwotherspoon Jun 24, 2024
927625f
chore: correctly merge main
jackwotherspoon Jun 24, 2024
57487ec
chore: remove stripping of trailing period
jackwotherspoon Jun 24, 2024
37790b7
chore: Merge branch 'main' into jackwotherspoon-patch-1
jackwotherspoon Jun 25, 2024
21783e9
chore: try removing trailing slash for SSL
jackwotherspoon Jun 25, 2024
a830f67
chore: add back in rstrip
jackwotherspoon Jun 25, 2024
35d98f5
chore: test adding period to hostname
jackwotherspoon Jun 25, 2024
38e58b7
chore: undo test
jackwotherspoon Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions google/cloud/alloydb/connector/connection_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ def create_ssl_context(self) -> ssl.SSLContext:

# create TLS context
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
# TODO: Set check_hostname to True to verify the identity in the
# certificate once PSC DNS is populated in all existing clusters.
context.check_hostname = False
# force TLSv1.3
context.minimum_version = ssl.TLSVersion.TLSv1_3

Expand Down
Loading