Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic issue in Cloud Run module vpc_connector argument #728

Closed
sethmoon opened this issue Jul 9, 2022 · 1 comment · Fixed by #729
Closed

Logic issue in Cloud Run module vpc_connector argument #728

sethmoon opened this issue Jul 9, 2022 · 1 comment · Fixed by #729
Labels
bug Something isn't working

Comments

@sethmoon
Copy link
Contributor

sethmoon commented Jul 9, 2022

The Cloud Run module contains a logic error if var.vpc_connector.create == false. The ternary operator is backwards, always going down the create branch if create is false.

A fix would be to either swap the true and false statements, or even simpler, just add a == false.

: try(var.vpc_connector.create, false)

Resolution: Change line to try(var.vpc_connector.create, false) == false

@ludoo ludoo added the bug Something isn't working label Jul 10, 2022
ludoo added a commit that referenced this issue Jul 10, 2022
@ludoo
Copy link
Collaborator

ludoo commented Jul 10, 2022

Thanks for spotting this!

ludoo added a commit that referenced this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants