Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shielded Folder - VertexML interoperability #1355

Merged
merged 4 commits into from
May 5, 2023

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented May 4, 2023

In this PR I Fix Shielded Folder - VertexML blueprints interoperability.

  • add kms keys output in the shielded folder blueprint
  • add missing service identity role on the vertex blueprint

@lcaggio lcaggio marked this pull request as ready for review May 4, 2023 12:19
@lcaggio lcaggio requested a review from juliocc May 4, 2023 12:19
@ludoo ludoo enabled auto-merge (squash) May 5, 2023 07:31
@lcaggio lcaggio removed the request for review from juliocc May 5, 2023 07:43
@ludoo ludoo merged commit 4d66623 into master May 5, 2023
@ludoo ludoo deleted the lcaggio/shielded-vertex branch May 5, 2023 07:54
lcaggio added a commit that referenced this pull request May 5, 2023
* Fix Shielded Folder - VertexML interoperability

* Fix README outputs

* Adding prefix for keyrings and update output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants