Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dataplex #1519

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Improve Dataplex #1519

merged 4 commits into from
Jul 24, 2023

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Jul 21, 2023

Improve dataplex module:

  • Add IAM support
  • support different type of assets

@lcaggio lcaggio marked this pull request as ready for review July 21, 2023 11:35
@lcaggio lcaggio requested review from juliocc and prabhaarya July 21, 2023 11:38
wiktorn
wiktorn reviewed Jul 21, 2023
View reviewed changes
modules/cloud-dataplex/main.tf Outdated Show resolved Hide resolved
modules/project/service-agents.yaml Outdated Show resolved Hide resolved
modules/cloud-dataplex/main.tf Outdated Show resolved Hide resolved
modules/cloud-dataplex/variables.tf Show resolved Hide resolved
modules/cloud-dataplex/main.tf Outdated Show resolved Hide resolved
@lcaggio lcaggio merged commit d46312a into master Jul 24, 2023
@lcaggio lcaggio deleted the lcaggio/dataplex-01 branch July 24, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@juliocc juliocc Awaiting requested review from juliocc

@prabhaarya prabhaarya Awaiting requested review from prabhaarya

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcaggio @wiktorn