Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCVE module first release #1590

Merged
merged 29 commits into from
Aug 21, 2023
Merged

GCVE module first release #1590

merged 29 commits into from
Aug 21, 2023

Conversation

eliamaldini
Copy link
Collaborator

Hi Team,
this is the module for a GCVE Private Cloud deployment.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, then it's good to go.

Remember to also link the module from

  • the modules folder README
  • the top-level repository folder

modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/main.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/main.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/main.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Outdated Show resolved Hide resolved
modules/gcve-private-cloud/main.tf Show resolved Hide resolved
modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/README.md Outdated Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Show resolved Hide resolved
modules/gcve-private-cloud/variables.tf Outdated Show resolved Hide resolved
@juliocc juliocc enabled auto-merge August 21, 2023 06:44
@juliocc juliocc merged commit 46af8b7 into master Aug 21, 2023
@juliocc juliocc deleted the elia-gcve branch August 21, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants