Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove unused ASN numbers from CloudNAT to avoid provider errors" #1626

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Aug 27, 2023

Turns out that ASN for CloudNAT was everything but useless.

  • the net-cloudnat module sets router_asn to 64514 by default, if not manually set.
  • 64514 goes in conflict with other router asn numbers set in different FAST stages (i.e. 2-networking-e-bgp), causing errors

I tried to reproduce what a user reported in the past (below):

Error: Attribute must be a whole number, got 4.200001024e+09
│   with module.prod-spoke-cloudnat["europe-west1"].google_compute_router.router[0],
│   on ../../../modules/net-cloudnat/[main.tf](http://main.tf/) line 32, in resource "google_compute_router" "router":
│   32:     asn = var.router_asn

Anyway, it doesn't seem to be reproducible.
I've also checked the APIs and the ASN 4200001024 should be definitely allowed.

I propose to revert this to fix the networking-e stage immediately. We may otherwise consider to use lower private ASN but not conflicting with ASN numbers used in FAST already (i.e. 65534?)

@LucaPrete LucaPrete requested a review from sruffilli August 27, 2023 21:07
@LucaPrete LucaPrete requested review from juliocc and ludoo August 27, 2023 21:07
@LucaPrete LucaPrete merged commit 4c64c15 into master Aug 28, 2023
@LucaPrete LucaPrete deleted the revert-1566-remove_asn_cnat branch August 28, 2023 07:33
LucaPrete added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants