Revert "Remove unused ASN numbers from CloudNAT to avoid provider errors" #1626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that ASN for CloudNAT was everything but useless.
router_asn
to64514
by default, if not manually set.64514
goes in conflict with other router asn numbers set in different FAST stages (i.e.2-networking-e-bgp
), causing errorsI tried to reproduce what a user reported in the past (below):
Anyway, it doesn't seem to be reproducible.
I've also checked the APIs and the ASN 4200001024 should be definitely allowed.
I propose to revert this to fix the
networking-e
stage immediately. We may otherwise consider to use lower private ASN but not conflicting with ASN numbers used in FAST already (i.e.65534
?)