Define and adopt standard IP ranges for FAST networking #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Sep 20, 2023
ludoo
approved these changes
Sep 20, 2023
juliocc
commented
Sep 20, 2023
sruffilli
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM in principle - only nit is that the allocated IP space is seldom realistic on real world scenarios.
Item for a future TODO: It would be handy to have a short document supporting users in designing their IP space, highlighting what's beyond VMs (especially PSA ranges for the different managed services, GKE cookiemonster).
This PR documents and adopts a consistent IP address plan for FAST networking stages Fixes #1644
juliocc
force-pushed
the
jccb/fast-ip-ranges
branch
from
361138d to
fa8cdff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents and adopts a consistent IP address plan for FAST networking stages
Fixes #1644
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py