Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bug fix to allow to use Secret Manager secrets to mount files in … #1703

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add bug fix to allow to use Secret Manager secrets to mount files in … #1703

merged 1 commit into from
Sep 25, 2023

Conversation

luigi-bitonti
Copy link
Contributor

…Cloud Function

The iterator _version_ is a map, used _version.value_ instead.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

wiktorn
wiktorn approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@juliocc juliocc merged commit e295a5e into GoogleCloudPlatform:master Sep 25, 2023
@wiktorn wiktorn mentioned this pull request Sep 25, 2023
Merged
4 tasks
@luigi-bitonti luigi-bitonti deleted the luigi-bitonti/cf_bug_fix branch September 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigi-bitonti @wiktorn @juliocc