Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bug fix in bucket local variable #1709

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

luigi-bitonti
Copy link
Contributor

@luigi-bitonti luigi-bitonti commented Sep 28, 2023

As you suggested, I made the change only to the local variable.
With this change, "bucket" variable will have the value of "var.bucket_name" only if the bucket has to be created.
Otherwise, it will have the name of the created bucket.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator

wiktorn commented Sep 28, 2023

Oh, now I see the bug :-) Thanks a lot.

Let me update this a bit

@wiktorn
Copy link
Collaborator

wiktorn commented Sep 28, 2023

Can you pull changes from here ? This adds tests that verify that the bug is actually fixed and also covers cloud functions v1.

@luigi-bitonti
Copy link
Contributor Author

luigi-bitonti commented Sep 28, 2023

I did it. I don't know if it was the correct way to merge your change, but trying to merge all the branch I saw that there are a lots file changed because your branch is is 81 commits behind GoogleCloudPlatform:master.
So I basically copied and pasted only the file changed on your last commit.

@wiktorn wiktorn enabled auto-merge (squash) September 28, 2023 10:01
@wiktorn
Copy link
Collaborator

wiktorn commented Sep 28, 2023

Thank you, I thought that I based that on your branch, but maybe I missed something. git cherry-pick should also work in this case.

@wiktorn wiktorn merged commit be5d9b8 into GoogleCloudPlatform:master Sep 28, 2023
@luigi-bitonti luigi-bitonti deleted the bug_fix_cf branch October 4, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants