Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields to Cloud Storage bucket #1745

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Add missing fields to Cloud Storage bucket #1745

merged 9 commits into from
Oct 10, 2023

Conversation

devuonocar
Copy link
Contributor

@devuonocar devuonocar commented Oct 10, 2023 •
edited
Loading

  • Added field default_event_based_hold
  • Added field requester_pays
  • Added field custom_placement_config

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc merged commit 4f91523 into GoogleCloudPlatform:master Oct 10, 2023
@devuonocar devuonocar deleted the devuonocar/add-features-to-gcs-module branch October 11, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devuonocar @juliocc