Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subnets depend on proxy only subnets #1762

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Make subnets depend on proxy only subnets #1762

merged 5 commits into from
Oct 16, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Oct 16, 2023

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc requested review from ludoo and juliodiez October 16, 2023 10:59
@wiktorn
Copy link
Collaborator

wiktorn commented Oct 16, 2023

Should we also add dependency to subnet_ids ?

@juliocc
Copy link
Collaborator Author

juliocc commented Oct 16, 2023

Should we also add dependency to subnet_ids ?

Absolutely. Done

@juliocc juliocc enabled auto-merge (squash) October 16, 2023 11:11
@juliocc juliocc merged commit 82f14fd into master Oct 16, 2023
@juliocc juliocc deleted the jccb/fix-subnet-deps branch October 16, 2023 11:39
@dominicrjames dominicrjames mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliodiez juliodiez juliodiez approved these changes

@ludoo ludoo Awaiting requested review from ludoo

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliocc @wiktorn @juliodiez