-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end tests for project module #1823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
force-pushed
the
wiktorn-project-examples
branch
from
October 28, 2023 21:47
82acd82
to
61e732f
Compare
wiktorn
force-pushed
the
wiktorn-project-examples
branch
2 times, most recently
from
October 29, 2023 08:24
9ef29bc
to
c7cd45f
Compare
wiktorn
force-pushed
the
wiktorn-project-examples
branch
from
October 29, 2023 08:54
c7cd45f
to
972e0ab
Compare
wiktorn
force-pushed
the
wiktorn-project-examples
branch
from
October 31, 2023 11:57
f03ea77
to
4e5a15e
Compare
wiktorn
force-pushed
the
wiktorn-project-examples
branch
from
October 31, 2023 12:00
4e5a15e
to
dda62bc
Compare
Will take me a while to go through this, plz be patient. :) |
ludoo
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thanks Wiktor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules/project
examplesModifying almost all examples in project module allowing to be run as end-to-end tests. The only one left is the one requiring org.
Interesting finding - module fails if no billing account is attached, unless you provide
auto_create_network = true
. This is probably due to the fact, that provider removes thedefault
network after project is created and this requirescompute
API, and this is only allowed if billing is attached.I decided to add billing account to all examples
Added one big example using
project_create = false
to test (hopefully) all cases with data resource in use.Bug fixes for
modules/project
logging
serviceE2E framework updates
Modifying E2E test framework to provide unique prefix on each test run. This is very useful here, and will be useful in any other areas where global uniqueness is required.
This results in dependency on providing
TF_VAR_prefix
variable hence making the*.tfvars
approach even less comfortable and I lean towards removing it. The problem is, that now theTF_VAR_prefix
is needed both in Terraform code and in Python code.Added new required resources to test harness:
Added support for
files=
clause in# tftest
line to end-to-end tests, to make sure that we are testing the same thing whether running standardtestes/examples
andtest/examples_e2e
Sample E2E tests run
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py