Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added create_before_destroy = true for self-managed certificates #1839

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Added create_before_destroy = true for self-managed certificates #1839

merged 1 commit into from
Nov 2, 2023

Conversation

apichick
Copy link
Collaborator

@apichick apichick commented Nov 2, 2023

Added create_before_destroy = true for self-managed certificates

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick enabled auto-merge November 2, 2023 13:08
wiktorn
wiktorn approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@apichick apichick merged commit 7a15eec into GoogleCloudPlatform:master Nov 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apichick @wiktorn