Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artifact-registry: Support cleanup policies #1891

Merged
merged 1 commit into from
Dec 1, 2023
Merged

artifact-registry: Support cleanup policies #1891

merged 1 commit into from
Dec 1, 2023

Conversation

noony
Copy link
Contributor

@noony noony commented Nov 30, 2023 •
edited
Loading

This PR aim to add support of cleanup policies for artifact registry module.

ie : https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/artifact_registry_repository#example-usage---artifact-registry-repository-cleanup

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@noony noony force-pushed the artifact-registries-cleanup-policies branch from c11e93b to da12b1d Compare November 30, 2023 10:31
juliocc
juliocc approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for the PR

Can you fix the linting issues?

modules/artifact-registry/README.md Outdated Show resolved Hide resolved
@wiktorn
Copy link
Collaborator

wiktorn commented Nov 30, 2023 •
edited by juliocc
Loading

Can you fix the linting issues?

In terms of linting issue, the message is a bit cryptic, but you need to just use alphabetic order of variables in variables.tf

@noony
Copy link
Contributor Author

noony commented Dec 1, 2023

I'm doing the changes now

@noony noony force-pushed the artifact-registries-cleanup-policies branch 2 times, most recently from 106ff0f to e8077b8 Compare December 1, 2023 10:14
@noony
Copy link
Contributor Author

noony commented Dec 1, 2023 •
edited
Loading

Thanks, fixes on readme and variables.tf lint commited

@noony noony force-pushed the artifact-registries-cleanup-policies branch from e8077b8 to 0de9c67 Compare December 1, 2023 10:15
@ludoo ludoo enabled auto-merge (squash) December 1, 2023 10:22
@ludoo ludoo merged commit 3a24848 into GoogleCloudPlatform:master Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noony @wiktorn @ludoo @juliocc