Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triggerer configuration for Composer #1916

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 10, 2023

  • Add triggerer configuration for Composer
  • make attributes optional where possibile
  • added blueprint to E2E test suite
  • other small improvements

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn marked this pull request as ready for review December 10, 2023 21:11
@wiktorn wiktorn requested a review from lcaggio December 10, 2023 21:11
@wiktorn wiktorn force-pushed the wiktorn-composer-defferable branch from ea9f316 to 39ef4b4 Compare December 10, 2023 21:18
@juliocc juliocc merged commit 886734e into master Dec 11, 2023
13 checks passed
@juliocc juliocc deleted the wiktorn-composer-defferable branch December 11, 2023 11:54
francesco-pavan-huware pushed a commit to francesco-pavan-huware/cloud-foundation-fabric that referenced this pull request Dec 11, 2023
ludoo added a commit that referenced this pull request Dec 11, 2023
…nance period in Cloud SQL module module (#1917)

* added maintenance window configuration to cloud sql

* Formatted code + generated readme

* Fixed readme errors (missing dots at the end of variables' description)

* Fixed typos + regenerated docs

* Added correct readme

* Collapsed "deny_maintenance_period" and "maintenance_window" variables into a single variable called "maintenance_config"

* Added input validation + some minor fixes

* Add trigger configuration for Composer (#1916)

* Added update_track variable validation

* Formatted variables + regenerated readme

---------

Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants