Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mtls on external application application load balancer #1979

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

Tazminia
Copy link
Contributor

@Tazminia Tazminia commented Jan 15, 2024

This PR provides the following:

  • Enable mTLS support on an external application load balancer by specifying a server tls policy.
  • Add .python-version to git ignore for contributors with multiple python versions on their machines.

This is my first attempt contributing to the project, please let me know if I need to do further checks or changes. Also, I had tests failing but none of them seemed related to what I am changing.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Jan 15, 2024

I think the new flag should go under var.https_proxy_config. @ludoo wdyt?

@juliocc
Copy link
Collaborator

juliocc commented Jan 16, 2024

@Tazminia instead of a top level variable, can you add a field to var.https_proxy_config?

Thanks!

@Tazminia
Copy link
Contributor Author

@juliocc of course. I will handle it and push again.

@Tazminia Tazminia force-pushed the taz/mtls-on-ext-app-lb branch from 4ed762b to dde4cd9 Compare January 16, 2024 16:29
@Tazminia
Copy link
Contributor Author

I moved the variable as requested.

@Tazminia Tazminia force-pushed the taz/mtls-on-ext-app-lb branch from 7957301 to d3be7e5 Compare January 16, 2024 16:47
@juliocc juliocc enabled auto-merge (squash) January 17, 2024 06:09
@juliocc juliocc merged commit 1c99bae into GoogleCloudPlatform:master Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants