Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests - vertex mlops and net-address #2072

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix e2e tests - vertex mlops and net-address #2072

merged 2 commits into from
Feb 13, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 13, 2024

  • Fix non empty plan after apply for google_notebooks_instance
  • Use different address in tests for net-address to avoid conflicts

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn enabled auto-merge (rebase) February 13, 2024 06:28
@wiktorn wiktorn merged commit 72183be into master Feb 13, 2024
13 checks passed
@wiktorn wiktorn deleted the wiktorn-fix_non_empty_plan branch February 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo