Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpipam blueprint #2119

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Fix phpipam blueprint #2119

merged 3 commits into from
Feb 29, 2024

Conversation

simonebruzzechesse
Copy link
Collaborator

Fix #2114

For the jquery / mixed content issues on PHPIPAM the proposed fix is based on the solution proposed on the official repo.

I also notice the error on the cloud sql password in output not available, the issue was related to the missing user type in cloud sql module preventing the password from being populated in the module's output. This was causing the blueprint output not being shown due to null value.

I had the chance to also update the following:

  • add http to https redirect in GLB
  • use local value for cloudsql_password output

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

blueprints/third-party-solutions/phpipam/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/main.tf Outdated Show resolved Hide resolved
@simonebruzzechesse simonebruzzechesse merged commit a5f8c50 into master Feb 29, 2024
13 checks passed
@simonebruzzechesse simonebruzzechesse deleted the bruzz/fix-phpipam branch February 29, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpipam outputs "invalid request" on "automatic database installation"
3 participants