-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define service attachment interface for lb modules and implement in internal LBs #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
changed the title
Define service attachment interface for ln modules and implement in net-lb-app-int
Define service attachment interface for lb modules and implement in net-lb-app-int
Feb 29, 2024
ludoo
changed the title
Define service attachment interface for lb modules and implement in net-lb-app-int
Define service attachment interface for lb modules and implement in internal LBs
Mar 1, 2024
wiktorn
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with psc-glb-and-armor
blueprint
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In keeping with the Fabric module design principles, PSC service attachment definition should be supported as an optional but integral part of our load balancer modules.
This PR defines the variable interface for a service attachment, and implements it in two key modules:
net-app-lb-int
with an interface supporting a single forwarding rulenet-lb-int
with the same interface but supporting multiple forwarding rulesThis is an actual working example of the multi-forwarding rules interface for the passthrough modules, the simpler single forwarding rule interface is identical but with a single object in its type:
This PR also contains a small fix to the
net-lb-int
that allows direct referencing the module-managed group by key, aligning it to the behaviour in more recent lb modules.It also does some code hygiene by adding missing TOCs to READMEs, and renaming the forwarding rules resource in the passthrough modules to conform it to our usual standard.