Added spanner-instance module #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apichick
force-pushed
the
spanner-instance
branch
5 times, most recently
from
034b168 to
ae82ca5
Compare
ludoo
requested changes
Jun 23, 2024
|
do not approve yet, I will do a change to you can have have instance_create flag like in the kms module |
I'll add a useless comment and approve so you can resolve and merge once you're ready :) |
ludoo
approved these changes
Jun 23, 2024
apichick
force-pushed
the
spanner-instance
branch
6 times, most recently
from
7653925 to
8444ae9
Compare
apichick
force-pushed
the
spanner-instance
branch
2 times, most recently
from
8146f78 to
64032ba
Compare
apichick
force-pushed
the
spanner-instance
branch
from
64032ba to
4a10dc0
Compare
jayBana
pushed a commit
to jayBana/cloud-foundation-fabric
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py