Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added firestore module #2374

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Added firestore module #2374

merged 1 commit into from
Jun 26, 2024

Conversation

apichick
Copy link
Collaborator

Added firestore module

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick force-pushed the firestore branch 4 times, most recently from a376558 to 5f35c7b Compare June 23, 2024 19:57
@apichick apichick requested a review from ludoo June 24, 2024 09:11
ludoo
ludoo requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple minor comments, remember to also add to top-level and modules level READMEs

modules/firestore/README.md Outdated Show resolved Hide resolved
modules/firestore/README.md Outdated Show resolved Hide resolved
modules/firestore/README.md Outdated Show resolved Hide resolved
modules/firestore/README.md Outdated Show resolved Hide resolved
@apichick apichick force-pushed the firestore branch 2 times, most recently from 0b36767 to 0f3107c Compare June 26, 2024 08:27
ludoo
ludoo approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple typos left to fix but merge once you're done :)

@apichick apichick merged commit 00080cd into master Jun 26, 2024
13 checks passed
@apichick apichick deleted the firestore branch June 26, 2024 12:18
@apichick apichick restored the firestore branch June 26, 2024 17:09
@apichick apichick deleted the firestore branch June 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apichick @ludoo