Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAST] Fix IAM bindings to impersonate resman CICD SAs at bootstrap stage #2411

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jayBana
Copy link
Collaborator

@jayBana jayBana commented Jul 8, 2024

Resolved an issue that appeared when applying FAST's bootstrap stage where merging blocks with conflicting key names were utilised to apply IAM bindings for service account impersonation between service accounts involved in CICD workload authorisation. This conflict resulted in only the final IAM binding from the merge block being applied, leading to incomplete and therefore incorrect IAM configurations that manifested itself during deployments using GitHub Actions.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@jayBana jayBana added bug Something isn't working on:FAST labels Jul 8, 2024
@jayBana jayBana requested a review from ludoo July 8, 2024 10:43
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Janos!

@jayBana jayBana merged commit 1aad2c6 into master Jul 8, 2024
17 checks passed
@jayBana jayBana deleted the jaybana/fast_cicd_sa_resman_fix branch July 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on:FAST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants