Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling topic creation in GCS module notification #2436

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jul 22, 2024

This allows passing in an existing topic to GCS notifications, so that the topic can be more easily configured from the outside, e.g. when using it for Storage Service jobs. It also fixes the storage transfer service agent in the project module, that needs jit.

@ludoo ludoo enabled auto-merge (squash) July 22, 2024 10:25
@ludoo ludoo disabled auto-merge July 22, 2024 10:33
@ludoo ludoo enabled auto-merge (squash) July 22, 2024 10:46
@ludoo ludoo merged commit 99ab796 into master Jul 22, 2024
17 checks passed
@ludoo ludoo deleted the ludo/gcs-notifications branch July 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants