Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic URL output to modules/artifact-registry #2448

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jul 25, 2024

All formats follow the same naming convention "$region-$format.pkg.dev". This PR simply renames the existing docker_image_path output to url.

@juliocc juliocc requested a review from ludoo July 25, 2024 07:38
@juliocc juliocc enabled auto-merge (squash) July 25, 2024 07:39
@juliocc juliocc merged commit 52b56aa into master Jul 25, 2024
17 checks passed
@juliocc juliocc deleted the jccb/docker-url branch July 25, 2024 08:33
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Aug 1, 2024
@ludoo ludoo changed the title Add generic URL output to modules/artifiact-registry Add generic URL output to modules/artifact-registry Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants