Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC-SC factory JSON Schemas #2477

Merged
merged 3 commits into from
Aug 7, 2024
Merged

VPC-SC factory JSON Schemas #2477

merged 3 commits into from
Aug 7, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Aug 7, 2024

As discussed, this only covers the VPC-SC module and does not yet integrate the schemas in FAST.

@ludoo ludoo requested a review from juliocc August 7, 2024 10:02
@ludoo ludoo enabled auto-merge (squash) August 7, 2024 10:15
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally - ❤️ ❤️ ❤️ - as this may help me a lot in the future and I was bitten by this beast already.

One comment regarding making the schemas a bit more specific - set "additionalProperties" to false on all objects in JSON schema.

The other improvement I see, is to mark more fields as required based on experience (but this may easily explode into big schema, if we need to use "anyOf" or similar approaches).

@ludoo
Copy link
Collaborator Author

ludoo commented Aug 7, 2024

Generally - ❤️ ❤️ ❤️ - as this may help me a lot in the future and I was bitten by this beast already.

One comment regarding making the schemas a bit more specific - set "additionalProperties" to false on all objects in JSON schema.

The other improvement I see, is to mark more fields as required based on experience (but this may easily explode into big schema, if we need to use "anyOf" or similar approaches).

schema needs to be a 1:1 translation of the variable type :)

@ludoo ludoo merged commit db7cb93 into master Aug 7, 2024
17 checks passed
@ludoo ludoo deleted the ludo/vpc-sc-schemas branch August 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants