Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind schemas to factory files, add support for groups in VPC-SC schema #2490

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Aug 9, 2024

Groups and principals are available in preview

Inspired by #2489, though this means that JSON schema is more strict than variables.tf


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

.vscode/settings.json Outdated Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Aug 9, 2024

Ca we retrofit the validation to variables.tf in both vpc-sc module and FAST stage?

@ludoo
Copy link
Collaborator

ludoo commented Aug 9, 2024

yaml.schemas does not seem to work

image

@wiktorn
Copy link
Collaborator Author

wiktorn commented Aug 9, 2024

yaml.schemas does not seem to work

image

Are you running multi-root workspace? Then this may be applicable, and you need specify yaml.schemas in root of the multi root workspace project.

@ludoo
Copy link
Collaborator

ludoo commented Aug 9, 2024

yaml.schemas does not seem to work
image

Are you running multi-root workspace? Then this may be applicable, and you need specify yaml.schemas in root of the multi root workspace project.

single root, but probably started as multiroot... :)

@wiktorn wiktorn merged commit 70bd037 into master Aug 9, 2024
17 checks passed
@wiktorn wiktorn deleted the wiktorn-json-schema-settings branch August 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants