feat: adds protos for the bpmetadata schema #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Apr 24, 2023
|
@bharathkkb - can you take another look? |
bharathkkb
approved these changes
Apr 24, 2023
|
@bharathkkb - FYI, I implemented the change for nested types in Go as well and since this is a breaking change, I'm incrementing it to v1.0.0 |
|
@g-awmalik pre-1.0 breaking changes are usually okay to do in minor updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point just need these protos uploaded so we can copy them over google3 to unblock the Marketplace team. I'll be adding build steps and start refactoring the bpmetadata code later to use protos for marshaling/un-marshaling metadata later on.