-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add provider version to metadata generation #2496
feat: add provider version to metadata generation #2496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @qz267! Few minor comments
@bharathkkb a friendly ping, all the comments addressed, this PR ready for another review. |
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, just two last comments
hmm, rerun the unit tests on local branch multiple times, all passing, might need to rerun the action job? |
This is from the CFT CLI Test:
Looks like maybe update the line ordering in cli/bpmetadata/int-test/goldens/golden-metadata.yaml? |
Updated golden metadata yml provider data. |
@qz267 I missed that |
Feature request from: b/356844884
Add ProviderVersion to metadata auto generation. Changes including:
parseBlueprintProviderVersions
function totfconfig.go
TestTFProviderVersion
totfconfig_test.go
parseBlueprintProviderVersions
togetBlueprintRequirements
function, which was called in the metadata generation process.requirements
block, added provider versions block.Checks:
make go_test
passingmake int_test
passingmake docker_go_lint
passing