-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update owners for backup-dr #2513
Open
ankushpareddy
wants to merge
3
commits into
GoogleCloudPlatform:master
Choose a base branch
from
ankushpareddy:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding myself and niharika as owners for backupDR terraform
ankushpareddy
requested review from
bharathkkb,
g-awmalik and
apeabody
as code owners
August 13, 2024 16:45
g-awmalik
approved these changes
Aug 14, 2024
g-awmalik
reviewed
Aug 14, 2024
@@ -806,7 +806,7 @@ locals { | |||
org = "GoogleCloudPlatform" | |||
short_name = "backup-dr" | |||
description = "Deploy Backup and DR appliances" | |||
owners = ["umeshkumhar"] | |||
owners = ["umeshkumhar", "ankushpa", "nkuravi"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ankushpa" & "nkuravi" are not valid usernames
g-awmalik
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace ldaps with Github usernames.
Updated with git username
Please join GoogleCloudPlatform github org for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding myself and niharika as owners for backupDR terraform