Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KRM benchmark example #982

Merged
merged 5 commits into from
Sep 7, 2021
Merged

feat: add KRM benchmark example #982

merged 5 commits into from
Sep 7, 2021

Conversation

bharathkkb
Copy link
Member

This adds a KRM benchmark example

  • Also moves pkg init and install-resource-group from DefaultInit to DefaultApply for krmt.
    Reasoning for this is because DefaultApply maybe run multiple times. In particular pkg init is not idempotent and will error out if a pkg is already inited.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approving this, I'd like to understand a bit more about what we're trying to benchmark. Do we want to benchmark kpt performance, or just kubectl apply behavior?

@bharathkkb
Copy link
Member Author

@morgante We are trying to benchmark KCC actuation time from object creation to resource actuation. In general across tools, we are trying to benchmark time from when a tool is invoked create N resources to when those resources are actually created.

@morgante
Copy link
Contributor

@morgante We are trying to benchmark KCC actuation time from object creation to resource actuation. In general across tools, we are trying to benchmark time from when a tool is invoked create N resources to when those resources are actually created.

Right, what I'm confused on is are we trying to measure kpt or KCC here? We can chat offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants