This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
fix: Cloud Ops permission errors #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was
linked to
issues
May 25, 2022
Closed
arbrown
approved these changes
May 25, 2022
There was a problem hiding this comment.
Consider tightening the permissions if possible. I think that the permissions needed for the service account could be somewhat reduced on the first two entries, but I'm not as close to the project, so I could be missing something and I'll trust your judgment.
arbrown
approved these changes
May 25, 2022
There was a problem hiding this comment.
Consider tightening the permissions if possible. I think that the permissions needed for the service account could be somewhat reduced on the first two entries, but I'm not as close to the project, so I could be missing something and I'll trust your judgment.
This was referenced Jun 15, 2022
Closed
Merged
daniel-sanche
added a commit
that referenced
this pull request
Jun 16, 2022
This was referenced Sep 19, 2022
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last few weeks, we've been seeing missing data in the Cloud Ops products on new sandboxes. I thought this was due to our outdated version of Istio, but after some experimentation, it looks like it can be patched by adding additional permissions on the GKE cluster service account
This PR fixes the issue by adding extra roles to the default compute instance service account, ensuring GCP observability client libraries can send data to Cloud Ops