Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for unix sockets (linux, mac, and windows) #1182

Merged
merged 34 commits into from
May 25, 2022
Merged

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 22, 2022

Fixes #84

@enocom enocom requested a review from kurtisvg April 22, 2022 15:23
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is failing on Windows - what do we need to do different for windows support?

cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg May 5, 2022 17:18
@enocom
Copy link
Member Author

enocom commented May 5, 2022

I've updated the Postgres e2e test to use pgx to help ease the transition to v2. As part of that, I discovered pgx does not support Unix sockets on Windows, but fixing that would be only a small amount of work. I've filed jackc/pgx#1199 and otherwise disabled the test on Windows for now.

@enocom enocom changed the title feat: add support for unix sockets feat: add support for unix sockets (linux, mac, and windows) May 5, 2022
@enocom
Copy link
Member Author

enocom commented May 9, 2022

Added supported for Unix sockets for Windows in pgx here: jackc/pgconn#114 and there's already a new release with the patch in it. I've updated the PR here to use that latest version.

cmd/root.go Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
internal/proxy/proxy.go Outdated Show resolved Hide resolved
@enocom enocom merged commit ca5c0a2 into v2 May 25, 2022
@enocom enocom deleted the unix-sockets branch May 25, 2022 18:05
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request May 26, 2022
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants