Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure the proxy with environment variables #1514

Merged
merged 9 commits into from
Nov 7, 2022
Merged

feat: configure the proxy with environment variables #1514

merged 9 commits into from
Nov 7, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Oct 26, 2022

Fixes #225.

@enocom enocom requested a review from a team October 26, 2022 19:31
@enocom
Copy link
Member Author

enocom commented Oct 26, 2022

I apologize for the size of this PR -- the bulk of the diff is from all the new tests. The new tests ensure that each flag may be set with a corresponding environment variable. In spite of the line count, the actual change here is quite small.

hessjcg
hessjcg approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

See comments on one optional change that could make the test cases easier to read.

cmd/root_test.go
}

// pointer returns a pointer to v
func pointer[T any](v T) *T {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

cmd/root_test.go Show resolved Hide resolved
cmd/root_test.go Outdated Show resolved Hide resolved
@kurtisvg kurtisvg self-requested a review October 31, 2022 16:26
kurtisvg
kurtisvg suggested changes Oct 31, 2022
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root_test.go Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg October 31, 2022 20:39
@enocom enocom merged commit 2a9d9a2 into main Nov 7, 2022
@enocom enocom deleted the config-from-env branch November 7, 2022 22:46
@release-please release-please bot mentioned this pull request Nov 7, 2022
Merged
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Dec 8, 2022
@enocom
feat: configure the proxy with environment variables
c9d152b 
This is a port of
GoogleCloudPlatform/cloud-sql-proxy#1514.
@enocom enocom mentioned this pull request Dec 8, 2022
Merged
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Dec 8, 2022
@enocom
feat: configure the proxy with environment variables (#197)
cfcf17d 
This is a port of
GoogleCloudPlatform/cloud-sql-proxy#1514.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@hessjcg hessjcg hessjcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuring proxy with environment variables
3 participants
@enocom @kurtisvg @hessjcg