Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reservation support in slurm sync for scheduled maintenance #2880

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add reservation support in slurm sync for scheduled maintenance #2880

merged 1 commit into from
Aug 15, 2024

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Aug 6, 2024 •
edited
Loading

This PR allows slurm to look for any google cloud maintenance event in the slurm cluster and reserve node during maintenance window.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 self-assigned this Aug 6, 2024
@harshthakkar01 harshthakkar01 added the release-key-new-features Added to release notes under the "Key New Features" heading. label Aug 6, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-maintenance branch 2 times, most recently from aaedcf8 to 61b2990 Compare August 7, 2024 22:01
@harshthakkar01 harshthakkar01 marked this pull request as ready for review August 7, 2024 22:02
@harshthakkar01 harshthakkar01 removed their assignment Aug 7, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Aug 7, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Aug 13, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-maintenance branch 2 times, most recently from db7b312 to 6e2d829 Compare August 14, 2024 18:11
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Aug 14, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-maintenance branch 3 times, most recently from e267684 to ef2a823 Compare August 14, 2024 20:24
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Aug 14, 2024
@harshthakkar01 harshthakkar01 merged commit cdb3ab5 into GoogleCloudPlatform:develop Aug 15, 2024
8 of 51 checks passed
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@harshthakkar01 harshthakkar01

Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @mr0re1