Add slurmgcp-managed
infix to resource policy name
#2892
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: improve collision avoidance, current matching pattern
"${cluster_name}-*"
is too relaxed.Consideration for max length of resource policy name, that
'slurm_cluster_name' must be a match of regex '^[a-z](?:[a-z0-9]{0,9})$'
= 10nodeset_name = substr(replace(var.name, "/[^a-z0-9]/", ""), 0, 14)
= 14len(job_id)
= 10len(nodes_chunk_id)
= 3len("slurmgcp-managed")
= 16len("${cluster_name}-slurmgcp-managed-${nodeset_name}-${job_id}-${nodes_chunk_id}")
= 10+1+16+1+14+1+10+3 = 56Testing:
Followups:
nodeset_name
into match pattern ofcleanup_compute.sh
(once cleanup-per-nodeset is implemented).Alternative considerations:
resource.random_uuid.cluster_id
- too long (36 chars); can create unexpected lifecycle dependencies;resource.random_uuid.short_cluster_id
- can create unexpected lifecycle dependencies;