Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing centos7 with rocky8 in vm-instance modules #2900

Merged
merged 1 commit into from
Aug 9, 2024
Merged

replacing centos7 with rocky8 in vm-instance modules #2900

merged 1 commit into from
Aug 9, 2024
+2 −2

Conversation

RachaelSTamakloe
Copy link
Collaborator

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-improvements Added to release notes under the "Improvements" heading. label Aug 9, 2024
rohitramu
rohitramu approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@rohitramu rohitramu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've triggered the lustre-vm test on this PR. Please ensure it succeeds before merging

@RachaelSTamakloe RachaelSTamakloe merged commit 4fbc43f into GoogleCloudPlatform:develop Aug 9, 2024
10 of 53 checks passed
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@RachaelSTamakloe RachaelSTamakloe

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RachaelSTamakloe @rohitramu