adding optional fields to redirect use of embedded modules to pull fr… #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om github with versioned tags
RachaelSTamakloe
added
the
release-key-new-features
mr0re1
reviewed
Aug 17, 2024
mr0re1
reviewed
Aug 17, 2024
tpdownes
reviewed
Aug 19, 2024
mr0re1
reviewed
Aug 21, 2024
mr0re1
reviewed
Aug 21, 2024
mr0re1
reviewed
Aug 21, 2024
mr0re1
reviewed
Aug 21, 2024
|
It would be also necessary to add unit tests. |
mr0re1
reviewed
Aug 22, 2024
mr0re1
reviewed
Aug 22, 2024
mr0re1
approved these changes
Aug 22, 2024
RachaelSTamakloe
merged commit cf022fb
into
GoogleCloudPlatform:develop
8 of 51 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds optional fields(toolkit_modules_url and toolkit_modules_version) to redirect use of embedded modules to pull modules from github when provided github url and module version