Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Parallelstore installation script to not move log folder for debian/ubuntu #2956

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Change Parallelstore installation script to not move log folder for debian/ubuntu #2956

merged 1 commit into from
Aug 20, 2024

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Aug 19, 2024 •
edited
Loading

-Added a hotfix for installation script as it fails to properly move the log folders for ubuntu+debian (reverting from a previous pr)

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added bug Something isn't working dependencies Pull requests that update a dependency file release-bugfix Added to release notes under the "Bug fixes" heading. and removed bug Something isn't working labels Aug 19, 2024
@harshthakkar01
Copy link
Contributor

/gcbrun

@tpdownes tpdownes changed the title Update parrallelstore version Update parallelstore version Aug 19, 2024
@abbas1902 abbas1902 force-pushed the origin/psstoreupdate branch 2 times, most recently from bcd49d5 to 829ff3b Compare August 19, 2024 22:17
@abbas1902 abbas1902 force-pushed the origin/psstoreupdate branch 2 times, most recently from 64b7b3d to f94d4be Compare August 19, 2024 22:41
@harshthakkar01
Copy link
Contributor

Update PR title and description to reflect the changes.

@abbas1902 abbas1902 removed the dependencies Pull requests that update a dependency file label Aug 19, 2024
@abbas1902 abbas1902 changed the title Update parallelstore version Change Parallelstore installation script to not move log folder for debian/ubuntu Aug 19, 2024
@abbas1902 abbas1902 added the do-not-merge Block merging of this PR label Aug 20, 2024
@abbas1902 abbas1902 removed the do-not-merge Block merging of this PR label Aug 20, 2024
@abbas1902 abbas1902 merged commit fc37f6e into GoogleCloudPlatform:develop Aug 20, 2024
9 of 52 checks passed
@abbas1902 abbas1902 deleted the origin/psstoreupdate branch August 20, 2024 22:48
@harshthakkar01 harshthakkar01 added release-chore To not include into release notes and removed release-bugfix Added to release notes under the "Bug fixes" heading. labels Aug 21, 2024
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshthakkar01 harshthakkar01 harshthakkar01 approved these changes

Assignees

@abbas1902 abbas1902

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbas1902 @harshthakkar01