Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent use of google provider 6.0 where breaking changes are in use #2978

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Aug 28, 2024

Restrict modules to use google provider <6.0 if they have been impacted by breaking changes in 6.0. See the upgrade guide for details of breaking changes:

https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_6_upgrade

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

The google_compute_instance has a breaking change in TPG 6.0 that we
must first address.
@tpdownes tpdownes added the release-bugfix Added to release notes under the "Bug fixes" heading. label Aug 28, 2024
@tpdownes tpdownes self-assigned this Aug 28, 2024
The google_container_node_pool resource has a breaking change in TPG 6.0
that we must first address.
@tpdownes tpdownes requested a review from mr0re1 August 28, 2024 16:01
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Aug 28, 2024
@tpdownes tpdownes marked this pull request as ready for review August 28, 2024 16:01
@tpdownes tpdownes changed the title Prevent use of google provider 6.0 in vm-instance module Prevent use of google provider 6.0 where breaking changes are in use Aug 28, 2024
@tpdownes tpdownes merged commit 0557557 into develop Aug 28, 2024
18 of 60 checks passed
@mr0re1 mr0re1 deleted the fix_guest_accelerator branch August 28, 2024 20:32
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants