Daisy: Recursively build child workflows in NewFromFile #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricEdens
force-pushed
the
child_wf_recurse
branch
from
428232e
to
53eb9d7
Compare
dntczdx
reviewed
Jul 14, 2021
|
Pausing review for a bit; while running some tests, OVF import is failing with |
EricEdens
force-pushed
the
child_wf_recurse
branch
from
dd8c156
to
2ea3ac8
Compare
|
Re-opening: Fixed the "Unresolved var" error, added unit test to verify it, and ran additional e2e tests locally. |
zoran15
reviewed
Jul 20, 2021
EricEdens
force-pushed
the
child_wf_recurse
branch
from
2ea3ac8
to
f050633
Compare
dntczdx
reviewed
Jul 21, 2021
zoran15
approved these changes
Jul 22, 2021
dntczdx
approved these changes
Jul 22, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dntczdx, EricEdens, zoran15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
EricEdens
added a commit
to EricEdens/compute-image-tools
that referenced
this pull request
Jul 26, 2021
zoran15
pushed a commit
that referenced
this pull request
Jul 26, 2021
EricEdens
added a commit
to EricEdens/compute-image-tools
that referenced
this pull request
Jul 27, 2021
EricEdens
added a commit
that referenced
this pull request
Jul 27, 2021
…sn't have variable. (#1701) This adds support for recursively reading child workflows. The feature was first added in #1693, but rolled back in #1700 due to a bug that it introduced. The issue: Variable instantiate occurs during populate, and callers expect that behavior. Callers also expect to define child workflow names using variables. Those are in conflict if we want to read child workflows before populate. To address this, I added a fix in eacb97a where child workflows are eagerly read only when they're fully specified. If the filename contains a variable, then the legacy behavior of reading the workflow during the step's populate is retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
workflow.NewFromFile's documentation says that it recursively reads subworkflows, that feature was never implemented. This PR ensures that sub workflows and included workflows are read whenworkflow.NewFromFileis called.To avoid double reading child workflow files, it also adds a guard in the respective
populatemethods.