Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

included the fix for dbsizing_facts not getting created issue to inco… #163

Merged
merged 2 commits into from
Jul 20, 2022
Merged

included the fix for dbsizing_facts not getting created issue to inco… #163

merged 2 commits into from
Jul 20, 2022

Conversation

smpawar
Copy link
Collaborator

@smpawar smpawar commented Jul 14, 2022

…rrect columns present in the json file

@smpawar smpawar requested a review from ersantosnet July 14, 2022 23:22
@ersantosnet ersantosnet added the bug Something isn't working label Jul 15, 2022
@smpawar
Copy link
Collaborator Author

smpawar commented Jul 20, 2022

@ersantosnet I changed the views back to DISABLED and pushed new commit.
Please review and approve.

ersantosnet
ersantosnet approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ersantosnet ersantosnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank YOU Sachin!

@ersantosnet ersantosnet merged commit 37b09e9 into main Jul 20, 2022
@cofin cofin deleted the bug162_dbsizing_facts_jsonsyntaxfix branch November 3, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersantosnet ersantosnet ersantosnet approved these changes

Assignees

@smpawar smpawar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smpawar @ersantosnet