Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell scripts to automate much of the ETL process. #180

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Add shell scripts to automate much of the ETL process. #180

merged 4 commits into from
Sep 13, 2022

Conversation

wpuziewicz
Copy link
Collaborator

Closes 177

@cofin cofin self-requested a review September 9, 2022 18:26
@cofin
Copy link
Collaborator

cofin commented Sep 9, 2022

closes #177

cofin
cofin reviewed Sep 9, 2022
View reviewed changes
db_assessment/2_load_op.sh Outdated Show resolved Hide resolved
cofin
cofin reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Added some initial feedback

cofin
cofin approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@cofin
Copy link
Collaborator

cofin commented Sep 9, 2022

/gcbrun

shane-borden
shane-borden reviewed Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@shane-borden shane-borden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good with this commit.

@shane-borden
Copy link
Collaborator

Tested against version 19.15 and 12.2.0.1. No issues on either test.

@cofin cofin merged commit e3651a9 into GoogleCloudPlatform:main Sep 13, 2022
@cofin
Copy link
Collaborator

cofin commented Sep 13, 2022

Thanks, @shane-borden . Merged.

This was referenced Sep 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shane-borden shane-borden shane-borden left review comments

@cofin cofin cofin approved these changes

Assignees

@wpuziewicz wpuziewicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpuziewicz @cofin @shane-borden