Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improve script handling with relative paths and added additional variables #184

Merged
merged 4 commits into from
Sep 15, 2022
Merged

FIX: Improve script handling with relative paths and added additional variables #184

merged 4 commits into from
Sep 15, 2022

Conversation

shane-borden
Copy link
Collaborator

Updated method for determining output and script directories, replaced hard coded project name and stopped failing on if the BQ dataset was already present.

Shane Borden added 2 commits September 15, 2022 20:06
…d hard coded project name and stopped failing on if the BQ dataset was already present
…d hard coded project name and stopped failing on if the BQ dataset was already present
@cofin cofin changed the title Sherpas 09152022 1 FIX: Improve script handling with relative paths and added additional variables Sep 15, 2022
cofin
cofin previously approved these changes Sep 15, 2022
Copy link
Collaborator

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @shane-borden

Copy link
Collaborator

@wpuziewicz wpuziewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wpuziewicz wpuziewicz merged commit 026c5f5 into GoogleCloudPlatform:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants