Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.4 #186

Merged
merged 70 commits into from
Sep 29, 2022
Merged

v3.0.4 #186

merged 70 commits into from
Sep 29, 2022

Conversation

cofin
Copy link
Collaborator

@cofin cofin commented Sep 27, 2022

  • Additional improvements to collection scripts.
  • refactoring and renaming variables to comply with pylint config

cofin and others added 30 commits September 16, 2022 14:15
@cofin
updated ignores
772b4ac
@cofin
chore: bumped version
605d9eb
@cofin
pretty print json
d810cf8
@cofin
renamed sample file
a668061
@cofin
added mkdocs config
12f08a7
@cofin
sample install scripts
375d035
@cofin
corrections to the upgradescript
d8bf586
@cofin
unhide the stdout
cdf2c50
@cofin
one more update
0c0bd49
@cofin
updates to build scripts location
86741e8
@cofin
script updates
0e42d76
@cofin
remove unused scripts
fd11cab
@cofin
updated scripts
5a3a537
@cofin
linting fixes
8b49dfb
move scripts to common scripts dir in root of project
234f703
move scripts to common scripts dir in root of project
f65ee88
@cofin
create logger
0ab5f72
@cofin
Merge branch 'v.3.0.3-dev' of https://github.com/cofin/oracle-databas…
fdd6df7 
…e-assessment into v.3.0.3-dev
@cofin
linting
215913e
@cofin
cleanup function names
ac97b41
@cofin
cleanup
be77b27
@cofin
begin refactoring process. Updated arguments for '--', began typing p…
1a537b8 
…rocessing, name variables according to pylint standard. Added default debug config
@cofin
corrected separator
a2f3e25
@cofin
revert a few transformers updates
6c23b70
add error handling and standardize script format
16ba753
add error handling and standardize script format
2c3ed4a
@cofin
project name substitution correction
8dedd89
@cofin
Merge branch 'v.3.0.3-dev' of https://github.com/cofin/oracle-databas…
3e934e9 
…e-assessment into v.3.0.3-dev
Update Error Handling after Testing
7a0bc3f
@cofin
correct typing in pandas dataframe
0898626
@cofin
Copy link
Collaborator Author

cofin commented Sep 27, 2022

/gcbrun

shane-borden
shane-borden previously approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@shane-borden shane-borden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked updated files and Readme for PR

@cofin cofin marked this pull request as draft September 27, 2022 21:19
@cofin cofin marked this pull request as ready for review September 28, 2022 21:27
@cofin cofin requested a review from shane-borden September 28, 2022 21:27
@cofin
Copy link
Collaborator Author

cofin commented Sep 29, 2022

/gcbrun

@cofin cofin mentioned this pull request Sep 29, 2022
Closed
@cofin cofin linked an issue Sep 29, 2022 that may be closed by this pull request
BUG: maxsqlscriptversion incorrect value of 2.0.5 leading to view creations getting skipped #167
Closed
@cofin cofin merged commit 085e075 into GoogleCloudPlatform:main Sep 29, 2022
@cofin cofin deleted the v.3.0.3-dev branch September 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpuziewicz wpuziewicz wpuziewicz approved these changes

@shane-borden shane-borden Awaiting requested review from shane-borden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: maxsqlscriptversion incorrect value of 2.0.5 leading to view creations getting skipped
3 participants
@cofin @shane-borden @wpuziewicz