fix: simplify build #438
Merged
fix: simplify build #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-borden
added a commit
that referenced
this pull request
May 21, 2024
* fix: simplify build (#438) * chore: fix cross compile and remove builds that aren't needed (#439) * Reduce error prominence in dmaSQLServerHWSpecs.ps1 See b/340537974 Previously: ``` Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:107 char:31 + ... ata.PhysicalCpuCount = (Get-WmiObject Win32_Processor @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:110 char:30 + ... Data.LogicalCpuCount = (Get-WmiObject Win32_Processor @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:113 char:33 + ... alOSMemoryBytes = (Get-WmiObject Win32_PhysicalMemory @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:119 char:25 + ... Data.PrimaryMAC = (Get-WmiObject Win32_NetworkAdapter @params | Where ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:122 char:26 + ... ddresses = (Get-WmiObject Win32_NetworkAdapterConfiguration @params | ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand ``` After these changes: ``` ERROR - Failed fetching machine HW specs of not-a-vm : The RPC server is unavailable. ``` --------- Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com> Co-authored-by: Shane Borden <sborden76@gmail.com>
cofin
added a commit
that referenced
this pull request
May 21, 2024
…reation scripts (#442) * fix: update docs and syntax error in user create statement * fix: add counter for total io metrics by processes * fix: update docs and fix column mapping for perfmon * fix: update user script with error handling and correct cursor flow * fix: refactor manual user permissions script * Reduce error prominence in dmaSQLServerHWSpecs.ps1 (#440) * fix: simplify build (#438) * chore: fix cross compile and remove builds that aren't needed (#439) * Reduce error prominence in dmaSQLServerHWSpecs.ps1 See b/340537974 Previously: ``` Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:107 char:31 + ... ata.PhysicalCpuCount = (Get-WmiObject Win32_Processor @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:110 char:30 + ... Data.LogicalCpuCount = (Get-WmiObject Win32_Processor @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:113 char:33 + ... alOSMemoryBytes = (Get-WmiObject Win32_PhysicalMemory @params | Measu ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:119 char:25 + ... Data.PrimaryMAC = (Get-WmiObject Win32_NetworkAdapter @params | Where ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand Get-WmiObject : The RPC server is unavailable. At C:\Users\SguegliL\CCSG2\dmaSQLServerHWSpecs.ps1:122 char:26 + ... ddresses = (Get-WmiObject Win32_NetworkAdapterConfiguration @params | ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (:) [Get-WmiObject], COMException + FullyQualifiedErrorId : GetWMICOMException,Microsoft.PowerShell.Commands.GetWmiObjectCommand ``` After these changes: ``` ERROR - Failed fetching machine HW specs of not-a-vm : The RPC server is unavailable. ``` --------- Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com> Co-authored-by: Shane Borden <sborden76@gmail.com> * chore: lint files * chore: bump version --------- Co-authored-by: Shane Borden <shaneborden@google.com> Co-authored-by: Yair Halberstadt <yairhalberstadt@gmail.com> Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.